WIP: s3 request file upload by garronej · Pull Request #1086 · InseeFrLab/onyxia

garronej · 2026-08-27T15:59:19Z

No description provided.

coderabbitai · 2026-08-27T15:59:30Z

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: d9244fca-e465-4455-8180-3cfabfaa5107

📥 Commits

Reviewing files that changed from the base of the PR and between 972c1a7 and 17eb1c7.

⛔ Files ignored due to path filters (1)

web/yarn.lock is excluded by !**/yarn.lock, !**/*.lock

📒 Files selected for processing (69)

web/package.json
web/scripts/unyamlify-env-local.ts
web/src/core/adapters/s3Client/s3Client.ts
web/src/core/ports/S3Client.ts
web/src/core/usecases/index.ts
web/src/core/usecases/s3ExplorerUiController/decoupledLogic/bucketPolicies.test.ts
web/src/core/usecases/s3ExplorerUiController/decoupledLogic/bucketPolicies.ts
web/src/core/usecases/s3ExplorerUiController/decoupledLogic/computeUploadStatusAtPrefix.ts
web/src/core/usecases/s3ExplorerUiController/decoupledLogic/getPublicAccessActionAndShouldShowShareAction.test.ts
web/src/core/usecases/s3ExplorerUiController/decoupledLogic/getPublicAccessActionAndShouldShowShareAction.ts
web/src/core/usecases/s3ExplorerUiController/selectors.ts
web/src/core/usecases/s3ExplorerUiController/thunks.ts
web/src/core/usecases/s3FileRequestCreationUiController/evt.ts
web/src/core/usecases/s3FileRequestCreationUiController/index.ts
web/src/core/usecases/s3FileRequestCreationUiController/selectors.ts
web/src/core/usecases/s3FileRequestCreationUiController/state.ts
web/src/core/usecases/s3FileRequestCreationUiController/thunks.ts
web/src/core/usecases/s3FileRequestUiController/decoupledLogic/getIsKnownS3HttpUrl.test.ts
web/src/core/usecases/s3FileRequestUiController/decoupledLogic/getIsKnownS3HttpUrl.ts
web/src/core/usecases/s3FileRequestUiController/decoupledLogic/getPresignedPostKeyPrefix.test.ts
web/src/core/usecases/s3FileRequestUiController/decoupledLogic/getPresignedPostKeyPrefix.ts
web/src/core/usecases/s3FileRequestUiController/index.ts
web/src/core/usecases/s3FileRequestUiController/selectors.ts
web/src/core/usecases/s3FileRequestUiController/state.ts
web/src/core/usecases/s3FileRequestUiController/thunks.ts
web/src/core/usecases/s3ProfilesCreationUiController/thunks.ts
web/src/core/usecases/s3ProfilesDetailsUiController/decoupledLogic/codeSnippets.ts
web/src/core/usecases/s3ProfilesDetailsUiController/selectors.ts
web/src/core/usecases/s3ShareObjectUiController/selectors.ts
web/src/ui/App/GlobalAlert.tsx
web/src/ui/App/LeftBar.tsx
web/src/ui/i18n/resources/de.tsx
web/src/ui/i18n/resources/en.tsx
web/src/ui/i18n/resources/es.tsx
web/src/ui/i18n/resources/fi.tsx
web/src/ui/i18n/resources/fr.tsx
web/src/ui/i18n/resources/it.tsx
web/src/ui/i18n/resources/nl.tsx
web/src/ui/i18n/resources/no.tsx
web/src/ui/i18n/resources/zh-CN.tsx
web/src/ui/i18n/types.ts
web/src/ui/pages/index.ts
web/src/ui/pages/s3Explorer/Page.tsx
web/src/ui/pages/s3Explorer/dialogs/S3ExplorerDialogs.tsx
web/src/ui/pages/s3Explorer/dialogs/S3FileRequestCreationDialog.tsx
web/src/ui/pages/s3Explorer/dialogs/S3SharePrefixDialog.tsx
web/src/ui/pages/s3FileRequest/Page.tsx
web/src/ui/pages/s3FileRequest/index.ts
web/src/ui/pages/s3FileRequest/route.ts
web/src/ui/shared/codex/S3ContextActionButton/S3ContextActionButton.stories.tsx
web/src/ui/shared/codex/S3DialogPrimitives/S3DialogPrimitives.tsx
web/src/ui/shared/codex/S3ExplorerMainView/S3ExplorerMainView.spec.md
web/src/ui/shared/codex/S3ExplorerMainView/S3ExplorerMainView.stories.tsx
web/src/ui/shared/codex/S3ExplorerMainView/S3ExplorerMainView.tsx
web/src/ui/shared/codex/S3FileRequest/S3FileRequest.spec.md
web/src/ui/shared/codex/S3FileRequest/S3FileRequest.stories.tsx
web/src/ui/shared/codex/S3FileRequest/S3FileRequest.tsx
web/src/ui/shared/codex/S3FileRequest/index.ts
web/src/ui/shared/codex/S3FileRequestCreationDialog/S3FileRequestCreationDialog.spec.md
web/src/ui/shared/codex/S3FileRequestCreationDialog/S3FileRequestCreationDialog.tsx
web/src/ui/shared/codex/S3FileRequestCreationDialog/index.ts
web/src/ui/shared/codex/S3SelectionActionBar/S3SelectionActionBar.stories.tsx
web/src/ui/shared/codex/S3SelectionActionBar/S3SelectionActionBar.tsx
web/src/ui/shared/codex/S3SharePrefixDialog/S3SharePrefixDialog.stories.tsx
web/src/ui/shared/codex/S3UriBar/S3UriBar.spec.md
web/src/ui/shared/codex/S3UriBar/S3UriBar.stories.tsx
web/src/ui/shared/codex/S3UriBar/S3UriBar.tsx
web/src/ui/shared/codex/getFilesToUploadFromDataTransfer.test.ts
web/src/ui/shared/codex/getFilesToUploadFromDataTransfer.ts

 _____________________________________________________________________________________________________________________________________________________
< Progress in a fixed context is almost always a form of optimization. Creative acts generally don't stay in the context that they are in. - Alan Kay >
 -----------------------------------------------------------------------------------------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).

✨ Finishing Touches

📝 Generate docstrings

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

…ow request upload when relevent

sonarqubecloud · 2026-09-29T23:36:30Z

Quality Gate passed

Issues
0 New issues
26 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.7% Duplication on New Code

See analysis details on SonarQube Cloud

chatgpt-codex-connector · 2026-09-29T23:36:31Z

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

garronej marked this pull request as draft August 27, 2026 15:59

github-advanced-security Bot found potential problems Aug 28, 2026

View reviewed changes

Comment thread web/src/core/usecases/s3FileRequestUiController/thunks.ts Fixed

garronej and others added 23 commits September 30, 2026 01:32

WIP: s3 request file upload

62d1fb5

Implement user facing upload request page

69fb73c

Done with upload request

c1ab41c

Add missing translations

fa7243b

Refactor s3 ui items exposed by the core

c01fc93

Refactor s3 selector

bec9aa3

Add more action in the uri bar

83ccf13

Securing request files feature

fe3a1a7

Remove em dashes

cce362c

Enable drag and drop folder in request file upload

90af913

Remove manipulation of legacy AWS S3 endpoint

cf704c9

Preset AWS region

ae6d55c

Stronger check for request files

9a186cc

Know where requested files are uploaded

baf18af

Remove gimmicky text

6500c77

Remove unessesary text

82b1d07

Add warning for request file about file overwrite

7c8918e

More transparency about how upload file works

1126c24

Fix the way the share link is rendered

974fd20

Rename the route

d8bab8a

Increase width of empty state components for better layout

5c4b084

Change default clientId for s3

be9f4bf

Only show public/private action when we have bucket policies, only sh…

17eb1c7

…ow request upload when relevent

garronej force-pushed the s3_file_request_upload branch from bbd2104 to 17eb1c7 Compare September 29, 2026 23:34

garronej marked this pull request as ready for review September 29, 2026 23:36

garronej merged commit 9fd4bd6 into main Sep 29, 2026
4 of 5 checks passed

garronej deleted the s3_file_request_upload branch September 29, 2026 23:38

Navigation Menu

WIP: s3 request file upload - #1086

WIP: s3 request file upload#1086
garronej merged 23 commits into
mainfrom
s3_file_request_upload

garronej commented Aug 27, 2026

Uh oh!

coderabbitai Bot commented Aug 27, 2026 •

edited

Loading

Uh oh!

Uh oh!

sonarqubecloud Bot commented Sep 29, 2026

Uh oh!

chatgpt-codex-connector Bot commented Sep 29, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

garronej commented Aug 27, 2026

Uh oh!

coderabbitai Bot commented Aug 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud Bot commented Sep 29, 2026

Quality Gate passed

Uh oh!

chatgpt-codex-connector Bot commented Sep 29, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai Bot commented Aug 27, 2026 •

edited

Loading